Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings in t(att)datainfo.c #774

Merged
merged 4 commits into from
Oct 5, 2024
Merged

Fix warnings in t(att)datainfo.c #774

merged 4 commits into from
Oct 5, 2024

Conversation

derobins
Copy link
Member

@derobins derobins commented Oct 5, 2024

No description provided.

@derobins derobins added Component - netCDF netCDF interface and nc* command-line tools Type - Improvement Improvements that don't add a new feature or functionality Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc. labels Oct 5, 2024
@derobins derobins changed the title Fix warnings in tdatainfo.c Fix warnings in t(att)datainfo.c Oct 5, 2024
@derobins derobins added Component - Testing Test code, GitHub workflows and removed Component - netCDF netCDF interface and nc* command-line tools labels Oct 5, 2024
@derobins
Copy link
Member Author

derobins commented Oct 5, 2024 •
edited
Loading

Eliminates 31 warnings (about 5% of the remaining warnings):

BEFORE
Total unique [non-ignored] warnings: 77
Ignored notes / supplemental warning lines [not counted in unique warnings]: 0
Duplicated warning lines [not counted in unique warnings]: 23
Total ignored warnings: 0
Total unique kinds of warnings: 11
Total files with warnings: 15

AFTER
Total unique [non-ignored] warnings: 46
Ignored notes / supplemental warning lines [not counted in unique warnings]: 0
Duplicated warning lines [not counted in unique warnings]: 7
Total ignored warnings: 0
Total unique kinds of warnings: 11
Total files with warnings: 12

@derobins derobins merged commit 87ec069 into HDFGroup:master Oct 5, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmribler bmribler bmribler approved these changes

@lrknox lrknox Awaiting requested review from lrknox lrknox is a code owner

@byrnHDF byrnHDF Awaiting requested review from byrnHDF byrnHDF is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

@schwehr schwehr Awaiting requested review from schwehr schwehr is a code owner

Assignees
No one assigned
Labels
Component - Testing Test code, GitHub workflows Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc. Type - Improvement Improvements that don't add a new feature or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@derobins @bmribler